-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove supabase, add postgres, fix tests #3807
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wonderful to see happening! So glad to see you two deleting all this code, thank you! We need to delete 10x this much :)
What are we going to do about other users of Supabase, for example: https://github.com/Seneca-CDOT/telescope/blob/d5b23e42523521f49fc77d1b76e3f408dd9a46d1/src/web/app/src/supabase.ts
@@ -38,6 +38,6 @@ PARSER_PORT = 10000 | |||
################################################################################ | |||
|
|||
# Supabase Secrets | |||
SUPABASE_URL=http://localhost/v1/supabase | |||
SUPABASE_URL="postgresql://postgres:your-super-secret-and-long-postgres-password@localhost/postgres" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DATABASE_URL
?
@@ -38,6 +38,6 @@ PARSER_PORT = 10000 | |||
################################################################################ | |||
|
|||
# Supabase Secrets | |||
SUPABASE_URL=http://localhost/v1/supabase | |||
SUPABASE_URL="postgresql://postgres:your-super-secret-and-long-postgres-password@localhost/postgres" | |||
SERVICE_ROLE_KEY=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyAgCiAgICAicm9sZSI6ICJzZXJ2aWNlX3JvbGUiLAogICAgImlzcyI6ICJzdXBhYmFzZS1kZW1vIiwKICAgICJpYXQiOiAxNjQxNzY5MjAwLAogICAgImV4cCI6IDE3OTk1MzU2MDAKfQ.DaYlNEoUrrEn2Ig7tqibS-PHK5vgusbcbo7X36XVt4Q |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These other vestiges of Supabase, can they go too?
}, | ||
}); | ||
|
||
if (!SUPABASE_URL || !SERVICE_ROLE_KEY) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this up, since you use the URL variable earler
@@ -12,11 +12,13 @@ FROM base as dependencies | |||
|
|||
COPY package.json ./ | |||
|
|||
COPY ./schema.prisma . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this file?
14f110d
to
88da4d2
Compare
88da4d2
to
f4fcb0a
Compare
f4fcb0a
to
4b3ee24
Compare
I won't bug you with reviews until you're ready. Let me know. |
4b3ee24
to
6577b61
Compare
Co-authored-by: Josue <[email protected]>
@humphd Finishing work on parser, @manekenpix is working on the SSO stuff- we're using this PR for both. Should be done soon! We don't think the supabase stuff in the frontend is being used by anything and will probably remove it. 😀 |
Fantastic, thanks for the update. Really glad for your help with this. Thank you both! |
Co-authored-by: Josue [email protected]
Issue This PR Addresses
Type of Change
Description
Steps to test the PR
Checklist